Implementation of HUD Portal for Reviewer Look #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a significant refactoring of the Ankimon reviewer look, transitioning from an
iframe-based system to a new Shadow DOM-based HUD portal. The BIGGEST FIX this makes is that most of the card's CSS will NOT affect appearance of the Ankimon GUI in the reviewer.
Key changes include:
New HUD Portal Implementation:
DOM-based HUD. This provides better isolation and control over the injected UI elements.
new HUD portal via reviewer.web.eval().
iframe-related injections and hooks.
Main Pokemon Sprite Flipping:
X-axis.
src/Ankimon/functions/create_css_for_reviewer.py for all display configurations (show_mainpkmn_in_reviewer
values 0, 1, and 2).
and *, *::before, *::after selectors) were identified and removed to allow the sprite transformation to take
effect.
Status Text Formatting:
ankimon_hud_portal.js and adding !important to font-weight: bold; in the inline styles generated by
create_status_html within src/Ankimon/functions/create_gui_functions.py to guarantee its application.