-
Notifications
You must be signed in to change notification settings - Fork 12
Team Overview in Deck Overview #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
h0tp-ftw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately this PR contains multiple changes, like the perform_quick_swap and the union changes in your other PR. please isolate only the relevant changes before we can merge the PR
Removed unused imports for cleaner code.
Removed quick team swap dialog action from the menu.
Unlucky-Life
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h0tp-ftw changed to only submit deck overview parts
h0tp-ftw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crash - because png_to_base64 isn't defined. Anki 25.09.2 (3890e12c) (ao)
Python 3.14.0 Qt 6.10.0 PyQt 6.10.0
Platform: Linux-6.17.7-300.fc43.x86_64-x86_64-with-glibc2.42
When loading Ankimon:
Traceback (most recent call last):
File "/var/home/uwu/Documents/vscode/anki-vscode/venv/lib64/python3.14/site-packages/aqt/addons.py", line 250, in loadAddons
import(addon.dir_name)
~~~~~~~~~~^^^^^^^^^^^^^^^^
File "/var/home/uwu/.var/app/net.ankiweb.Anki/data/Anki2/addons21/Ankimon/init.py", line 136, in
from .gui_classes.overview_team import *
File "/var/home/uwu/.var/app/net.ankiweb.Anki/data/Anki2/addons21/Ankimon/gui_classes/overview_team.py", line 13, in
from ..utils import png_to_base64
ImportError: cannot import name 'png_to_base64' from 'Ankimon.utils' (/var/home/uwu/.var/app/net.ankiweb.Anki/data/Anki2/addons21/Ankimon/utils.py)
i have added a commit to define it, but it didn't fix the issue - feel free to change from there.
also the image binary was printed in the terminal, flooding it - so i couldn't see what was happening
Adds the View of Pokemon Team in Deck Browser