fix #122: httpx streaming via iter_raw raises httpx.StreamConsumed
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FWIW both commits (the new regression test, fix) have already been tested individually within my fork, please see https://github.com/petarmaric/pook/actions for details. |
sarayourfriend
approved these changes
Feb 14, 2024
Collaborator
sarayourfriend
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the PR and new tests 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122.
Credit where credit's due, as was the case of #91 this PR is also inspired by work done in https://github.com/Colin-b/pytest_httpx, the proposed fix corresponding to https://github.com/Colin-b/pytest_httpx/blob/b91bae4ec02a35e692700356dfe3753a20e32fc8/pytest_httpx/_httpx_mock.py#L269-L275