call pook.off in the end of pook.activate wrapper function #145
Conversation
sarayourfriend
left a comment
There was a problem hiding this comment.
Thank you for the issue and PR @shift0965 🙏 Can you add a unit test for this fix? You will also need to update activate_async to fix the same problem for async tests: https://github.com/h2non/pook/blob/master/src/pook/activate_async.py#L26
We'll need a unit test for each as well. If you would like guidance on adding the tests, let me know and I can give some pointers.
|
Thank you for you feedback! I just added test cases for each scenario and let me know if there are any further adjustments you like me to make. |
sarayourfriend
left a comment
There was a problem hiding this comment.
LGTM! One small change needed to get the tests to run (the test function needs to be async), but I'll commit that for you and then CI should pass and I can merge and release today 🙂
Thanks again for the contribution 🎉
This PL is for this issue