Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@i110
Copy link
Contributor

@i110 i110 commented Oct 11, 2018

Fixes #1869.

Actually there's no need to grab content-length in h2o_hpack_parse_response_headers at this time, so removed it.

@kazuho
Copy link
Member

kazuho commented Oct 11, 2018

Thank you for working on the issue.

Actually there's no need to grab content-length in h2o_hpack_parse_response_headers at this time, so removed it.

I am not sure if that is the correct solution. Our semantics is to have the excepted content-length stored in h2o_req_t::res.content_length. Compress handler uses that to determine if we need to compress the output on the fly.

IMO, we should follow the semantics, and also handle inconsistency between the content-length and the actual size of the response under the semantics we have established in #1490.

@kazuho
Copy link
Member

kazuho commented Oct 11, 2018

Discussed. We set res.content_length in proxy.c. There is no need to handle content_length as a special header in parse_response.

@kazuho kazuho merged commit 7ef178c into master Oct 11, 2018
@kazuho
Copy link
Member

kazuho commented Oct 11, 2018

IMO, we should follow the semantics, and also handle inconsistency between the content-length and the actual size of the response under the semantics we have established in #1490.

@i110 will have a follow-up commit to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants