Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stop applying filters multiple times #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
i110 merged 6 commits into from
Oct 31, 2018
Merged

stop applying filters multiple times #1891

i110 merged 6 commits into from
Oct 31, 2018

Conversation

@i110
Copy link
Contributor

@i110 i110 commented Oct 31, 2018

Currently H2O.next has a problem that filters and prefilters will be applied to the response multiple times, that is:

/:
  - mruby-handler: proc {|env| H2O.next.call(env) }
  - file.dir: /path/to/doc_root
  - header.add: "x-foo: FOO"

responds x-foo: FOO 2 times. This PR addresses that issue.

kazuho
kazuho reviewed Oct 31, 2018
View reviewed changes
kazuho
kazuho reviewed Oct 31, 2018
View reviewed changes
@kazuho
Copy link
Member

kazuho commented Oct 31, 2018

LGTM. Please merge once the CI succeeds.

@i110 i110 merged commit 109b0f4 into master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazuho kazuho kazuho left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@i110 @kazuho