Don't push a path if a connection is closing. #1902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
925d14a to
8c91934
Compare
This might happen if a link is being pushed in a reverse proxying environment: proxy.c would be handling HTTP/1 headers when the HTTP/2 side of the connection has been set to `H2O_HTTP2_CONN_STATE_IS_CLOSING`
8c91934 to
9ac056e
Compare
Member
|
Nice catch. We need this, because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might happen if a link is being pushed in a reverse proxying
environment: proxy.c would be handling HTTP/1 headers when the HTTP/2
side of the connection has been set to
H2O_HTTP2_CONN_STATE_IS_CLOSING