[mruby/middleware.c] Fix invalid read on the stack #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*((struct sockaddr_storage *)&sin);` would cause a read that's larger than `sin`, reaching to other parts of the stack. We fix this with a memcpy that only reads `sizeof(sin);` bytes.
Member
|
Nice catch! How about 8f27b03? |
Member
Author
…pends on the enviroment, avoid invalid read on stack due to sizeof(sockaddr_storage) > sizeof(sockaddr_in)
Member
Author
Member
|
Oh thank you for moving this forward. Please merge once the CI succeeds. |
Member
Author
|
done, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*((struct sockaddr_storage *)&sin);would cause a read that's largerthan
sin, reaching to other parts of the stack. We fix this with amemcpy that only reads
sizeof(sin);bytes.