[http2][http3] tighten header validation #3256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e have been raising an hard error if huffman encoding is used, or allowing it if huffman is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out and discussed in #3250, RFC 9113 (2nd revision of HTTP/2 specification) tightened the requirements against HTTP/2 intermediaries rejecting invalid header fields.
This PR makes necessary changes so that we are conformant to the new revision. Specifically, header fields carrying values surrounded by whitespace are rejected, and also those with empty (i.e., zero-length) names.
Latter is not an explicit requirement of RFC 9113 though RFC 9110 defines field names as carrying at least one character.