Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(setResponseHeaders): fix types to allow partial header names #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(setResponseHeaders): fix types to allow partial header names #607

merged 1 commit into from
Jan 12, 2024

Conversation

@dargmuesli
Copy link
Contributor

@dargmuesli dargmuesli commented Jan 6, 2024 •
edited by danielroe
Loading

🔗 Linked issue

#542
resolves #614

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently, the record requires all keys to be set.
See: https://github.com/maevsi/maevsi/actions/runs/7428213670/job/20215223408

Adding Partial allows value to be undefined though. I guess the idea for undefined values would be to remove the corresponding header, but that change can be reverted of course!

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dargmuesli dargmuesli changed the title fix(response): allow partial http header name fix(types): allow partial http header name Jan 6, 2024
@codecov
Copy link

codecov bot commented Jan 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae91fc8) 74.65% compared to head (33a65bc) 74.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   74.65%   74.67%   +0.01%     
==========================================
  Files          47       47              
  Lines        4246     4248       +2     
  Branches      574      571       -3     
==========================================
+ Hits         3170     3172       +2     
  Misses       1061     1061              
  Partials       15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dargmuesli dargmuesli mentioned this pull request Jan 6, 2024
Merged
1 task
@joshmossas joshmossas mentioned this pull request Jan 9, 2024
Closed
@danielroe danielroe requested a review from pi0 January 11, 2024 11:20
danielroe
danielroe reviewed Jan 11, 2024
View reviewed changes
@dargmuesli
fix(response): allow partial http header name
33a65bc 
Correct the type specification in #601.
@pi0 pi0 changed the title fix(types): allow partial http header name fix(setResponseHeaders): fix types to allow partial header names Jan 12, 2024
@pi0 pi0 merged commit a402808 into h3js:main Jan 12, 2024
@dargmuesli dargmuesli deleted the patch-1 branch January 12, 2024 10:53
@dargmuesli
Copy link
Contributor Author

@pi0 can we have a patch release for this? 🙈

@devunt
Copy link

devunt commented Jan 17, 2024

This issue blocks upgrading h3 to 1.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe left review comments

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.10.0] setResponseHeaders expects every possible header key to be included

4 participants

@dargmuesli @devunt @pi0 @danielroe