Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(getRequestWebStream): reuse buffered body if available #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2024
Merged

fix(getRequestWebStream): reuse buffered body if available #616

merged 3 commits into from
Jan 15, 2024

Conversation

@oscartbeaumont
Copy link
Contributor

🔗 Linked issue

#615

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Refer to issue #615

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@oscartbeaumont oscartbeaumont mentioned this pull request Jan 14, 2024
Closed
10 tasks
@pi0 pi0 changed the title fix: using request body from getRequestWebStream stalls with Nitro's Deno Deploy/Vercel Edge runtime fix(getRequestWebStream): handle req.body Jan 15, 2024
@pi0 pi0 changed the title fix(getRequestWebStream): handle req.body fix(getRequestWebStream): use if set req.body Jan 15, 2024
@codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (845eeca) 74.67% compared to head (3a670f0) 74.51%.

Files Patch % Lines
src/utils/body.ts 66.66% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   74.67%   74.51%   -0.17%     
==========================================
  Files          47       47              
  Lines        4249     4269      +20     
  Branches      574      576       +2     
==========================================
+ Hits         3173     3181       +8     
- Misses       1061     1073      +12     
  Partials       15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 changed the title fix(getRequestWebStream): use if set req.body fix(getRequestWebStream): reuse buffered body if available Jan 15, 2024
pi0
pi0 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have pushed few more refactors to cover more of edge cases using readRawBody

@pi0 pi0 merged commit 751fa45 into h3js:main Jan 15, 2024
@pi0 pi0 mentioned this pull request Jan 15, 2024
Closed
@atinux atinux mentioned this pull request Jan 31, 2024
Closed
@pi0 pi0 mentioned this pull request Oct 21, 2024
Closed
wooorm-arcjet added a commit to arcjet/arcjet-js that referenced this pull request Oct 15, 2025
@wooorm-arcjet
fix(nuxt): stash body for h3 functions
cda15fb 
Related-to: h3js/h3#616.
Related-to: arcjet/examples#53.
@wooorm-arcjet wooorm-arcjet mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oscartbeaumont @pi0