Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(getRequestHost): return first host from X-Forwarded-Host list #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

fix(getRequestHost): return first host from X-Forwarded-Host list #993

merged 2 commits into from
Apr 16, 2025

Conversation

@Ingramz
Copy link
Contributor

@Ingramz Ingramz commented Mar 19, 2025

Fixes #992

Reproduction:

import { createApp, createRouter, defineEventHandler, getRequestHost } from "h3";

export const app = createApp();

const router = createRouter();
app.use(router);

router.get(
  "/",
  defineEventHandler((event) => {
    return getRequestHost(event, { xForwardedHost: true });
  }),
);

curl -H "X-Forwarded-Host: proxy1.tld, proxy2.tld" http://localhost:3000 - Should return proxy1.tld

@Ingramz Ingramz requested a review from pi0 as a code owner March 19, 2025 12:17
pi0
pi0 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (a58d7c9) to head (95a7514).
Report is 251 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   77.83%   83.98%   +6.14%     
==========================================
  Files          47       36      -11     
  Lines        4286     2666    -1620     
  Branches      611      688      +77     
==========================================
- Hits         3336     2239    -1097     
+ Misses        933      425     -508     
+ Partials       17        2      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 merged commit cb9fc47 into h3js:main Apr 16, 2025
5 checks passed
@aturingmachine aturingmachine mentioned this pull request Jul 25, 2025
Closed
@kricsleo kricsleo mentioned this pull request Jul 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getRequestHost returns comma separated list of hosts in some proxy setups

2 participants

@Ingramz @pi0