-
Notifications
You must be signed in to change notification settings - Fork 292
docs: updated visualization for dispatch request lifecycle #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β π’ Thoughts on this report? Let us know! |
|
Two suggestions from the current diagram:
If it helps, this is actual code. |
|
couldn't make mermaid display flowchart well, here are some attempts made, which graph suit the documentation most? |
|
Updated with simplified seq diagram. How do you think? %%{init: {'theme':'neutral'}}%%
sequenceDiagram
participant MiddlewareA as Middleware1(event, next)
participant MiddlewareB as Middleware2(event, next)
participant Route as RouteHandler(event)
MiddlewareA-->MiddlewareA: onRequest(event)
MiddlewareA->>+MiddlewareB: await next()
MiddlewareB-->MiddlewareB: onRequest(event)
MiddlewareB->>+Route: await next()
Route->>Route: RouteHandler(event)
Route-->>-MiddlewareB: rawBody
MiddlewareB-->>-MiddlewareA: rawBody
MiddlewareA-->MiddlewareA: sendResponse(event, rawBody)
|
|
This looks simpler and easier to understand than the one I suggested! |
Updated visualization for dispatch request lifecycle to be clearer.
MiddlewareAhas to be in vertical, or else it's too long to to see the details.