Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: return a Response for no-content #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2025
Merged

fix: return a Response for no-content #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbdee41
construct response object
randName Jul 31, 2025
29c41d4
chore: apply automated updates
autofix-ci[bot] Jul 31, 2025
908f965
update return type for sendNoContent
randName Jul 31, 2025
223c2f8
chore: apply automated updates
autofix-ci[bot] Jul 31, 2025
acfc876
Merge branch 'main' into nocontent-response
pi0 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/_deprecated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ export function sendStream(
}

/** @deprecated Please use `return noContent(event)` */
export const sendNoContent: (event: H3Event, code?: number) => "" = noContent;
export const sendNoContent: (event: H3Event, code?: number) => Response =
noContent;

/** @deprecated Please use `return redirect(event, code)` */
export const sendRedirect: (
Expand Down
5 changes: 4 additions & 1 deletion src/utils/cors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ export function appendCorsHeaders(event: H3Event, options: CorsOptions): void {
* // Your code here
* });
*/
export function handleCors(event: H3Event, options: CorsOptions): false | "" {
export function handleCors(
event: H3Event,
options: CorsOptions,
): false | Response {
const _options = resolveCorsOptions(options);
if (isPreflightRequest(event)) {
appendCorsPreflightHeaders(event, options);
Expand Down
5 changes: 3 additions & 2 deletions src/utils/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { FastResponse } from "srvx";
import type { H3Event } from "../event.ts";
import { sanitizeStatusCode } from "./sanitize.ts";
import {
Expand All @@ -16,7 +17,7 @@ import {
* @param event H3 event
* @param code status code to be send. By default, it is `204 No Content`.
*/
export function noContent(event: H3Event, code?: number): "" {
export function noContent(event: H3Event, code?: number): Response {
const currentStatus = event.res.status;

if (!code && currentStatus && currentStatus !== 200) {
Expand All @@ -31,7 +32,7 @@ export function noContent(event: H3Event, code?: number): "" {
event.res.headers.delete("content-length");
}

return "";
return new FastResponse(null, event.res);
}

/**
Expand Down