Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(response): do not double merge prepared headers in nested error handler #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2025
+9 −2
Merged

fix(response): do not double merge prepared headers in nested error handler #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da28e98
fix(response): do not double merge prepared headers in nested error h…
pi0 Oct 21, 2025
35b29f8
Merge branch 'main' into fix/nested-double-headers
pi0 Oct 21, 2025
09d7afc
add test
pi0 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function prepareResponse(
}

// Note: Only check _headers. res.status/statusText are not used as we use them from the response
if (!preparedHeaders) {
if (!preparedHeaders || nested) {
return val; // Fast path: no headers to merge
}
try {
Expand Down
9 changes: 8 additions & 1 deletion test/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,21 @@ describeMatrix("errors", (t, { it, expect }) => {
});

it("error headers", async () => {
t.app.config.onError = async () => {
return new Response("error", {
status: 501,
headers: { "set-cookie": "error=1" },
});
};

t.app.get("/", async (event) => {
event.res.headers.set("set-cookie", "test=1");
throw new HTTPError({ status: 501 });
});

const res = await t.fetch("/");
expect(res.status).toBe(501);
expect(res.headers.get("set-cookie")).toBe("test=1");
expect(res.headers.getSetCookie()).toEqual(["error=1", "test=1"]);

t.errors = [];
});
Expand Down