fix: adjust pathname for mounted sub-app routed middleware #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes middleware not inheriting base URL when sub-app is mounted. Middleware matchers now correctly see adjusted pathname (without base prefix), while route handlers continue to see the full pathname. This fix adjusts `event.url.pathname` before calling child middleware, then restores it before calling the route handler (via wrapped next callback). The try/finally block ensures pathname is always restored. Changes: - Modified H3Core.mount() to adjust pathname for child middleware - Added wrappedNext callback to restore pathname before route handler - Added comprehensive tests for middleware mounting scenarios - Updated existing test to use relative paths in mounted middleware Test Results: - All 712 functional tests pass - Bundle size increased by ~150 bytes (acceptable tradeoff) Fixes h3js#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes middleware not inheriting base URL when sub-app is mounted. Middleware matchers now correctly see adjusted pathname (without base prefix), while route handlers continue to see the full pathname.
This fix adjusts
event.url.pathnamebefore calling child middleware, then restores it before calling the route handler (via wrapped next callback). The try/finally block ensures pathname is always restored.Changes:
Test Results:
resolves #1208