RFC: Cookies with Max-Age=0 should be permitted
#7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
There's an erratum in the spec about this. I think we could justify tolerating negative numbers for the same reason, but this fixes the real-world bug. 👍
|
Thanks! Do I need to do anything to port the fix between release versions? |
|
Nope, we'll merge it forward into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble parsing a 'discard cookie'
Set-Cookieheader from Play Framework which specified aMax-Age=0.Upon examination http4s ignores cookies with a Max-Age that doesn't contain the characters 1-9. RFC 6265 is murky on this point, specifying both non-zero digits in the syntax but also saying that zero or lower numbers should be parsed in the prose of section 5.2.2. I think it's safe to say that setting a
Max-Age=0is common practice when invalidating a cookie.The http4s client shouldn't then hide it from users in Responses by failing to parse, zero values should be permitted in the parser.