Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix EmptyCustomLabels and SizedSeq0 singleton creation issue #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix EmptyCustomLabels and SizedSeq0 singleton creation issue #7511

merged 3 commits into from
Sep 6, 2024

Conversation

@dj707chen
Copy link
Contributor

@dj707chen dj707chen commented Sep 5, 2024 •
edited
Loading

After consuming the latest SNAPSHOT of http4s-core, this http4s-prometheus-metrics build failed:

org.http4s.metrics.prometheus.PrometheusServerMetricsSuite:
==> X org.http4s.metrics.prometheus.PrometheusServerMetricsSuite.A http routes with a prometheus metrics middleware should register a 2xx response  0.039s java.lang.NullPointerException: null
    at org.http4s.metrics.prometheus.Prometheus.createMetricsCollection(Prometheus.scala:344)
    at org.http4s.metrics.prometheus.Prometheus.buildCustomMetricsOps(Prometheus.scala:131)
    at org.http4s.metrics.prometheus.Prometheus.build(Prometheus.scala:126)
    at org.http4s.metrics.prometheus.Prometheus$.metricsOps(Prometheus.scala:408)
    at org.http4s.metrics.prometheus.PrometheusServerMetricsSuite.$anonfun$buildMeteredRoutes$1(PrometheusServerMetricsSuite.scala:236)

The root cause is that the singleton creation of EmptyCustomLabels is calling the apply(), which just return the singleton instance, thus it is in infinite loop.

SizedSeq0 has the same issue.

This PR fixes these two issues by calling constructor explicitly.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels Sep 5, 2024
@samspills samspills added this to the 0.23.28 milestone Sep 5, 2024
@dj707chen dj707chen changed the title Fix EmptyCustomLabels and SizedSeq0 singleton creation Fix EmptyCustomLabels and SizedSeq0 singleton creation issue Sep 5, 2024
danicheg
danicheg approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final abstract really seems abnormal

@samspills samspills merged commit 895f328 into http4s:series/0.23 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samspills samspills samspills approved these changes

@danicheg danicheg danicheg approved these changes

Assignees

No one assigned

Labels

module:core series/0.23 PRs targeting 0.23.x

Projects

None yet

Milestone

0.23.28

Development

Successfully merging this pull request may close these issues.

3 participants

@dj707chen @samspills @danicheg