-
Notifications
You must be signed in to change notification settings - Fork 805
merge 0.23 to main #7728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge 0.23 to main #7728
Conversation
Restore binary compatibility with <0.23.31 in dsl.Statuses
Update changelog.md for 0.23.32
This PR makes `[bot]` a valid markdown link in our changelog.md This feels silly, but I don't think this is the last time we'll forget to remove the `[bot]` text that GitHub adds now.
Make `[bot]` a link in changelog.md
We usually remove in main all the deprecations that come from 0.23. |
176b1ad to
3db885c
Compare
|
I've removed the deprecated pieces, but of course please review and double check that I've not done something mad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting in my sincere apologies to anyone coming from the future, trying to figure out what the hell we had been doing here. Sorry, guys!
| @deprecated("now called UnprocessableContent", since = "0.23.31") | ||
| val UnprocessableEntity: Status = UnprocessableContent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change corresponds to the spirit of the 1.0 series, but I can't imagine what a pain it'd be to migrate from 0.23 to 1.0 for any brave (desperate?) people in the end...
|
I will come back this evening and release a new 1.0 milestone |
I didn't think about it in the merge to main on Monday evening, should I go ahead and delete the deprecated
UnprocessableEntityand related logic for the main branch?Or maybe at this point should that be a separate PR to main instead of doing it in the merge?