Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samspills
Copy link
Contributor

I didn't think about it in the merge to main on Monday evening, should I go ahead and delete the deprecated UnprocessableEntity and related logic for the main branch?
Or maybe at this point should that be a separate PR to main instead of doing it in the merge?

http4s-steward bot and others added 21 commits September 23, 2025 04:29
Restore binary compatibility with <0.23.31 in dsl.Statuses
This PR makes `[bot]` a valid markdown link in our changelog.md
This feels silly, but I don't think this is the last time we'll forget to remove the `[bot]` text that GitHub adds now.
Make `[bot]` a link in changelog.md
@samspills samspills self-assigned this Sep 25, 2025
@mergify mergify bot added module:dsl docs Relates to our website or tutorials labels Sep 25, 2025
@danicheg
Copy link
Member

I go ahead and delete the deprecated UnprocessableEntity and related logic for the main branch?

We usually remove in main all the deprecations that come from 0.23.

@mergify mergify bot added the module:core label Sep 29, 2025
@samspills samspills force-pushed the sam/0.23.32-merge-to-main branch from 176b1ad to 3db885c Compare September 29, 2025 13:27
@samspills
Copy link
Contributor Author

I've removed the deprecated pieces, but of course please review and double check that I've not done something mad

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting in my sincere apologies to anyone coming from the future, trying to figure out what the hell we had been doing here. Sorry, guys!

Comment on lines -182 to -183
@deprecated("now called UnprocessableContent", since = "0.23.31")
val UnprocessableEntity: Status = UnprocessableContent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change corresponds to the spirit of the 1.0 series, but I can't imagine what a pain it'd be to migrate from 0.23 to 1.0 for any brave (desperate?) people in the end...

@samspills samspills merged commit ccf8e05 into main Oct 1, 2025
26 checks passed
@samspills
Copy link
Contributor Author

I will come back this evening and release a new 1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Relates to our website or tutorials module:core module:dsl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants