Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rminnich
Copy link
Collaborator

No description provided.

@rminnich rminnich requested review from djdv and hugelgupf February 11, 2025 22:34
@rminnich
Copy link
Collaborator Author

needed for the cpu command on plan 9 ... the irony just keeps comin'
:-)

@djdv
Copy link
Collaborator

djdv commented Feb 11, 2025

This passes vet and seems fine.
However, I'm wondering if we can rename xattr_windows.go to xattr_other.go and just update the build tag since the implementations are the same.

Edit: oh no the CI is outdated.

@djdv
Copy link
Collaborator

djdv commented Feb 11, 2025

Something like this maybe?
If it causes build problems we can drop that commit.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.64%. Comparing base (6f4f11e) to head (a12db31).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   55.25%   58.64%   +3.39%     
==========================================
  Files          37       32       -5     
  Lines        4749     4679      -70     
==========================================
+ Hits         2624     2744     +120     
+ Misses       1918     1731     -187     
+ Partials      207      204       -3     
Flag Coverage Δ
macos-latest-unit ?
ubuntu-latest-unit ?
ubuntu-vm-amd64 58.64% <ø> (-3.03%) ⬇️
ubuntu-vm-arm 56.87% <ø> (-3.26%) ⬇️
ubuntu-vm-arm64 56.87% <ø> (-3.26%) ⬇️
windows-latest-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugelgupf
Copy link
Owner

@rminnich can you rebase?

Did GitHub get rid of the button that let's me do that?

@djdv
Copy link
Collaborator

djdv commented Apr 3, 2025

Giving explicit permission to --autosquash my name out of the --fixup commit if you want to (or whatever seems best).
It probably doesn't need to be its own commit and likely just convolutes the diff.

@hugelgupf hugelgupf merged commit abc96d2 into hugelgupf:main Apr 20, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants