Refactor suppression of warning at experimental import#4629
Merged
qgallouedec merged 2 commits intohuggingface:mainfrom Dec 5, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
I'm merging this one so that I can use it in #4575 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor experimental warning suppression,
This PR refactors how to suppress warnings during imports from
trl.experimental: instead of setting a temporary environment variable, it uses a localized warning filter.Why this is better:
Experimental warning handling improvements:
TRLExperimentalWarningintrl/import_utils.pyto distinguish experimental API warnings from generic user warnings.temporary_envcontext manager (resetting the environment variableTRL_EXPERIMENTAL_SILENCE) with a newsuppress_experimental_warningcontext manager throughout the codebase, including all trainer and config modules.trl/experimental/__init__.pyto use the newTRLExperimentalWarningclass instead of the genericUserWarning.