Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Test FSDP2#4813

Merged
qgallouedec merged 4 commits intomainfrom
test_fsdp2
Jan 13, 2026
Merged

Test FSDP2#4813
qgallouedec merged 4 commits intomainfrom
test_fsdp2

Conversation

@qgallouedec
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests are not passing. We should investigate why.

@qgallouedec
Copy link
Member Author

I don't think it's related to this PR (Tests / Distributed smoke tests (pull_request) passes)

@albertvillanova
Copy link
Member

I think you are right and that was caused by some issue on the GitHub side. Anyway, I reran the failing tests just in case.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, there is an issue on the GitHub side, unrelated to this PR.

@qgallouedec qgallouedec merged commit 335a17e into main Jan 13, 2026
8 of 12 checks passed
@qgallouedec qgallouedec deleted the test_fsdp2 branch January 13, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants