This repository was archived by the owner on Mar 30, 2018. It is now read-only.
Add files filter #264
Merged
Add files filter #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2017 08:18
…n this option and files found by finder will be made
theofidry
suggested changes
Aug 19, 2017
src/Command/Humbug.php
Outdated
|
|
||
| if (isset($paths)) { | ||
| $finder->filter(function (SplFileInfo $file) use ($paths) { | ||
| return \in_array($file, $paths); |
There was a problem hiding this comment.
the leading backslash can be removed
| ->addOption( | ||
| 'path', | ||
| 'p', | ||
| InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, |
There was a problem hiding this comment.
no need for the !, a . is enough :)
README.md
Outdated
| humbug --path=src/Data/NewClass.php --path=src/Driver/Driver.php | ||
| ``` | ||
|
|
||
| This in no way restricts the initial Humbug check on the overall test suite which |
|
@holysleeper the changes LGTM but the tests are still failing |
|
@theofidry I saw the fails, I will fix them asap :). Thanks. |
theofidry
reviewed
Aug 31, 2017
| } | ||
|
|
||
| if (isset($paths)) { | ||
| if (!is_null($paths) && count($paths) > 0) { |
There was a problem hiding this comment.
what was the problematic value? I though it could only be an array or null
There was a problem hiding this comment.
When --path option is not present, the default value is an empty array. Because of that "return in_array" is always false.
theofidry
approved these changes
Aug 31, 2017
|
Thanks very much @holysleeper :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the option 'path' for full path files to mutate. Files from path with be intersected with the files found by Symfony/Finder using config directory and 'file' option.
Ex:
Config:
{ "timeout": 10, "source": { "directories": [ "src" ], "excludes": [ "vendor", "tests" ] }, "logs": { "json": "humbug/humbuglog.json" } }Command:
Files found by Symfony/Finder:
Running the command with the config above the mutated files will be: