Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@martin-rueegg
Copy link
Contributor

@martin-rueegg martin-rueegg commented Sep 23, 2023

What kind of change does this PR introduce?

  • Refactor

Does this PR introduce a breaking change?

  • Yes

UUID (e.g. used in guid columns) must actually be valid UUIDs, meaning

  • valid format and characters
  • unique at least within any given table

Applied to

  • contentcontainer.guid
  • content.guid
  • file.guid
  • space.guid
  • user.guid

The PR fulfills these requirements

  • It's submitted to the next branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch from 1efad91 to 9d901fc Compare September 23, 2023 08:28
@martin-rueegg martin-rueegg mentioned this pull request Sep 23, 2023
5 tasks
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch 2 times, most recently from b101036 to fc8644b Compare September 25, 2023 18:19
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch from fc8644b to 400b1f5 Compare December 1, 2023 11:22
@martin-rueegg martin-rueegg marked this pull request as ready for review December 1, 2023 12:05
Copy link
Contributor

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-rueegg Thanks for the contribution. Please see my remarks below.

@martin-rueegg martin-rueegg mentioned this pull request Dec 10, 2023
6 tasks
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch from 86fc95c to a156efd Compare December 11, 2023 11:25
@martin-rueegg martin-rueegg changed the base branch from next to develop December 11, 2023 11:26
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch 2 times, most recently from 2d958dd to b75300a Compare December 11, 2023 11:29
@martin-rueegg martin-rueegg requested a review from luke- December 11, 2023 11:31
@luke- luke- added this to the v1.16 milestone Dec 11, 2023
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch 4 times, most recently from 5f513e6 to de27e12 Compare December 15, 2023 09:54
@martin-rueegg martin-rueegg requested a review from luke- December 15, 2023 10:22
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch from de27e12 to 0bee9a5 Compare December 15, 2023 11:22
@martin-rueegg martin-rueegg force-pushed the enh/improve-uuid-validator-2 branch from 0bee9a5 to 5223a33 Compare December 15, 2023 13:23
@luke- luke- added this pull request to the merge queue Dec 15, 2023
Merged via the queue into humhub:develop with commit 428c7a3 Dec 15, 2023
@martin-rueegg martin-rueegg deleted the enh/improve-uuid-validator-2 branch December 16, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants