Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Limit group filter on people page #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yurabakhtin wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Limit group filter on people page #7494

yurabakhtin wants to merge 2 commits into from

Conversation

@yurabakhtin
Copy link
Contributor

@yurabakhtin yurabakhtin commented Apr 11, 2025

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
https://github.com/humhub/humhub-internal/issues/608

@yurabakhtin yurabakhtin requested a review from luke- April 11, 2025 15:03
@luke-
Copy link
Contributor

luke- commented Apr 12, 2025

@yurabakhtin Do I understand correctly that there is no limit in the current version?

@what-the-diff
Copy link

what-the-diff bot commented Apr 14, 2025

PR Summary

  • Update to CHANGELOG.md
    A new entry has been added, related to an improved feature allowing users to limit the number of group filters on the people page. This enhancement will provide a more manageable and streamlined user experience.

  • Modification to getGroupOptions method in PeopleFilters.php

    • A new parameter has been introduced named $limit with a default number set as 200. This would control the maximum number of groups that can be shown to a user at once.
    • This change also includes a behavior modification, where the returned group query results are restrained based on the $limit parameter. This ensures better performance and efficiency when displaying user groups.

@yurabakhtin
Copy link
Contributor Author

yurabakhtin commented Apr 14, 2025

@luke- If you mean the current version is develop-v1.18.0 or master-v1.17.3, then yes, it has no the limit.
I have added the limit to 200 groups in this PR, or don't I understand the task corectly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luke- luke- Awaiting requested review from luke-

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yurabakhtin @luke-