Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated MetricsSystem::createLabelledGauge #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Remove deprecated MetricsSystem::createLabelledGauge #8299

merged 1 commit into from
May 9, 2025

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 13, 2025

PR description

Removing MetricsSystem::createLabelledGauge that is deprecated since 24.12.0

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the remove-deprecated-createLabelledGauge branch from 4323c11 to a15db12 Compare February 13, 2025 14:28
@macfarla
Copy link
Contributor

To be on the safe side, should we wait until after pectra mainnet release to make this breaking change?

@fab-10
Copy link
Contributor Author

fab-10 commented Feb 17, 2025

To be on the safe side, should we wait until after pectra mainnet release to make this breaking change?

There should be no risks, but also there is no hurry in merging this, so I am fine to wait after the hard fork

@macfarla macfarla added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label Mar 13, 2025
@github-actions
Copy link

This pr is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Apr 13, 2025
@fab-10
Copy link
Contributor Author

fab-10 commented Apr 14, 2025

This pr is stale because it has been open for 30 days with no activity.

This will be merged after Pectra

@github-actions github-actions bot removed the Stale label Apr 15, 2025
@fab-10 fab-10 force-pushed the remove-deprecated-createLabelledGauge branch from 92ccc05 to 5355ab5 Compare May 9, 2025 08:06
@fab-10 fab-10 enabled auto-merge (squash) May 9, 2025 08:07
@fab-10 fab-10 merged commit 7cab4bf into hyperledger:main May 9, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macfarla macfarla macfarla approved these changes

Assignees

No one assigned

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fab-10 @macfarla