Add --cache-last-block-headers flag to cache the last n block headers #9223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stored in the blockchain Signed-off-by: Ameziane H. <[email protected]>
Signed-off-by: Ameziane H. <[email protected]>
Signed-off-by: Ameziane H. <[email protected]>
fab-10
reviewed
Sep 25, 2025
Contributor
fab-10
left a comment
There was a problem hiding this comment.
LGTM, just few typos and suggestion for code improvements.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/test/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchainTest.java
Outdated
Show resolved
Hide resolved
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchainTest.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
Contributor
|
Forgot to say to also add a CHANGELOG entry |
Signed-off-by: Ameziane H. <[email protected]>
fab-10
approved these changes
Sep 25, 2025
Signed-off-by: ahamlat <[email protected]>
Signed-off-by: Ameziane H. <[email protected]>
10 tasks
AliZDev-v0
pushed a commit
to AliZDev-v0/besu
that referenced
this pull request
Oct 5, 2025
…hyperledger#9223) * Add --cache-last-block-headers flag to cache the last n block headers stored in the blockchain Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ali Zhagparov <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 13, 2025
…hyperledger#9223) * Add --cache-last-block-headers flag to cache the last n block headers stored in the blockchain Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR continues the work started in #9193 to improve performance under non-finality conditions.
It includes a new flag
--cache-last-block-headers, to store the last block headers from the blocks persisted to the blockchain.This flag works with
--cache-last-blockflag with no issues, because we can imagine a case where we want to store the last 1024 blocks and the last 10_000 block headers.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests