Add Sepolia configs and address baseFee at genesis case #2933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fee-at-genesis when baseFee is otherwise unspecified in the genesis config Signed-off-by: garyschulte <[email protected]>
ensure london-at-genesis has a baseFee allow override of the initial baseFee via config and overrides Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
da3dd24 to
6d18543
Compare
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
matkt
requested changes
Oct 21, 2021
Contributor
matkt
left a comment
There was a problem hiding this comment.
Quick question regarding the getGenesisBaseFeePerGas method
| return getBaseFeePerGas() | ||
| .map(Optional::of) | ||
| .orElseGet(() -> Optional.of(BASEFEE_AT_GENESIS_DEFAULT_VALUE)) | ||
| .filter(z -> 0L == getConfigOptions().getLondonBlockNumber().orElse(-1L)); |
Contributor
There was a problem hiding this comment.
Do we have to return -1 or to throw an exception in this case ?
Contributor
Author
There was a problem hiding this comment.
we will return an empty Optional, the -1L will fail to match the filter if we do not have a london block number at all
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…2933) Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #2920
Changelog