Make OpenMP optional #357
Merged
Make OpenMP optional #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously OpenMP was necessary to build the project. Missing OpenMP should no longer fail the build. This can now be configured with CMAKE flags analog to CUDA. RAYX_ENABLE_OPENMP builds with OpenMP support if available (Default ON). RAYX_REQUIRE_OPENMP makes it required (Default: OFF). Rayx should already fall back to single threaded sequential execution if the corresponding Alpaka flags for faster devices are disabled. (see Platform.h)
Forces a build without OpenMP support by setting the RAYX_ENABLE_OPENMP to OFF. No changes to the current behavior.
|
Optional dependency and new CMAKE flags still need to be documented in the build instructions. Probably after or as part of #340 ? |
ichinii
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously OpenMP was necessary to build the project. With this, a missing OpenMP Installation should no longer fail the build.
This might be useful if a faster Accelerator like CUDA is available.
The behaviour be configured with CMAKE flags (analog to CUDA):
RAYX_ENABLE_OPENMP builds with OpenMP support if available (Default ON).
RAYX_REQUIRE_OPENMP makes it required (Default: OFF).
Rayx should already fall back to single threaded sequential execution, if the corresponding Alpaka flags for faster Accelerators are disabled (seePlatform.h).
Disabling OpenMP is only possible at compile time, there is no command line option for rayx to chose which CPU Accelerator is used.