Crystal as Element #380
Merged
Crystal as Element #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 95a1949 Author: F Zotter <[email protected]> Date: Tue Jun 10 14:16:53 2025 +0200 add crystal test commit 786ffd3 Author: F Zotter <[email protected]> Date: Tue Jun 10 12:57:08 2025 +0200 use rand.h commit ef72329 Author: F Zotter <[email protected]> Date: Tue Jun 10 11:44:52 2025 +0200 ommit cuda clamp commit 109467c Author: F Zotter <[email protected]> Date: Tue Jun 10 11:37:47 2025 +0200 ommit clamp commit 5e890f2 Author: F Zotter <[email protected]> Date: Tue Jun 10 11:22:59 2025 +0200 use complex::Complex commit 6be52e0 Author: F Zotter <[email protected]> Date: Fri Jun 6 07:01:53 2025 +0200 check crystal commit f124b20 Author: Jannis Maier <[email protected]> Date: Thu Jun 5 14:09:28 2025 +0200 fix: add missing values to types array commit 49f4e59 Author: F Zotter <[email protected]> Date: Thu Jun 5 16:48:57 2025 +0200 intensity for crystal commit 76eee63 Author: F Zotter <[email protected]> Date: Tue Jun 3 15:02:28 2025 +0200 crystal MD doku commit c2a9fa7 Author: F Zotter <[email protected]> Date: Thu May 22 10:23:10 2025 +0200 e field commit b348901 Author: F Zotter <[email protected]> Date: Tue May 6 11:08:06 2025 +0200 first implementation calc of e field for crystal clean up commit 0f0960b Author: F Zotter <[email protected]> Date: Tue Apr 8 18:27:02 2025 +0200 add crystal as behaviour start crystal calculation mostly done commit 2a4e184 Author: Sven Erdem <[email protected]> Date: Wed May 7 14:13:46 2025 +0200 add stokes and electric field conversion add crystal elementstring rebase fix
ichinii
reviewed
Jun 24, 2025
|
|
||
| ### Bragg Angle Calculation | ||
|
|
||
| \\[ |
There was a problem hiding this comment.
for markdown the math mode is accessible through $
so:
$\theta_B = \arcsin\left(\frac{\lambda}{2d}\right)$
becomes
There was a problem hiding this comment.
Not sure this is supported for mdBook. The convention seems to be what @fannyzotter did: mdBook Wiki Math
There was a problem hiding this comment.
Yes, ours does not support
\[
\theta_B
\]
notation
ichinii
reviewed
Jun 24, 2025
| r.m_field = reflect_field; | ||
|
|
||
| double reflectivity = intensity(reflect_field); | ||
| if (!sampleReflectivity(reflectivity, rand)) { |
There was a problem hiding this comment.
dont use montecarlo method here. instead multiply the electric field with the reflectivity to adjust the intensity.
ichinii
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.