Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fannyzotter
Copy link
Member

@fannyzotter fannyzotter commented Jul 16, 2025

Type of Change

  • Bug fix (non breaking change, fixing an issue)
  • New feature
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Documentation / Wiki update

Description

This introduces the optical Element Foil. Some preliminary dokumentation is included. But it will be adapted soon.
Fixed #issue

Optional notes for reviewer:
rayx-ui crashes when clicking the "surface" dropdown in Foil ( but also in gratings.

✅ Pre-Merge Checklist

Important

By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.

Please complete each item before requesting a review.

  • Code follows the project's coding standards
  • Unit tests for new functionality are added and pass
  • All existing tests pass
  • Resolved TODO Comments (prefer new issues instead)
  • Documentation, if applicable, including:
    • Doxygen comments for any new rayx-core API functions
    • Helpful inline comments where needed for clarity
    • Wiki pages, e.g. updated build instructions, new Element etc.
  • Commits:
    • Use clear and readable commit messages (e.g. Conventional commits)
    • Squash and rebase onto master if individual commits don’t add value
    • Ensure linear commit history (required by master)

Copy link
Collaborator

@ichinii ichinii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@fannyzotter fannyzotter merged commit be2efd1 into master Jul 16, 2025
6 checks passed
@fannyzotter fannyzotter deleted the foil branch July 16, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Optical Elements: Foil (and Lense) - important step towards a general ray tracer

3 participants