Feature/advance electric field #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fannyzotter
reviewed
Jul 16, 2025
|
|
||
| /// Convert photon energy (eV) to wavelength (nm) | ||
| RAYX_FN_ACC | ||
| inline double energyToWaveLength(const double energy) { return inm2eV / energy; } |
There was a problem hiding this comment.
In Utils.cpp there already is the function hvlam(double x) that calculates the wavelength from the energy. Maybe delete it and switch to yours. Also the inm2eV canstant is available with more digits.
8314ee8 to
0126922
Compare
not actually advance, to ensure tests run at this point
override seeded tests
0126922 to
cb4c454
Compare
|
looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Now the recorded event's electric field is phase shifted according to the traveled path length. this enables the possibility for interference analysis
✅ Pre-Merge Checklist
Important
By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.
Please complete each item before requesting a review.
TODOComments (prefer new issues instead)masterif individual commits don’t add valuemaster)