Fix params overflow, UTF-8 and ruby includes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas J. Reichel <[email protected]>
As described by `astoeckel`, if feeding
```
echo -en "\e["`printf '99;%.0s' {0..15}`m | ./test
```
parameters land behind the cb->params array,
which is not a sever issue since the `num_params` element
behind the buffer gets reset afterwards. However, he
suggested that this undefined behavior should be fixed.
I implemented his suggestion in this commit.
Signed-off-by: Andreas J. Reichel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I tried to include fixes for
Please note that especially the buffer check might change the original intention of the code to explicitely
behave as the original hardware state machine. I have no way of checking what the original hardware does.
Also, original hardware did not support UTF-8, however in modern terminal emulators, UTF-8 is a must.
I understand that the original author might not want to include these changes because of that. But everybody
else, feel free to do so :)
kr