Fix bool conversion bug in Vulkan code generator#8067
Merged
steven-johnson merged 2 commits intomainfrom Feb 7, 2024
Merged
Conversation
address of a byte vector, instead of its contents to builder.declare_constant()
steven-johnson
approved these changes
Feb 5, 2024
Contributor
|
Mac failure is irrelevant. (Does this need a test?) |
Vulkan codegen works as expected
Contributor
Author
|
Yes! Test case added. |
steven-johnson
approved these changes
Feb 6, 2024
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Fix bug in Vulkan code generator that was incorrectly passing the address of a byte vector, instead of its contents to builder.declare_constant() * Add bool_predicate_cast correctness test to verify bool conversion for Vulkan codegen works as expected --------- Co-authored-by: Derek Gerstmann <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIRVEmitter::convert_to_bool(...) was incorrectly passing the address of a byte vector, instead of its contents to builder.declare_constant(...)
As reported here:
#8064