Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: make log writer configurable #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

feat: make log writer configurable #283

merged 1 commit into from
Mar 10, 2025

Conversation

@antiphp
Copy link
Contributor

@antiphp antiphp commented Mar 10, 2025

Goal of this PR

Keep using os.Stdout for the logger, but make os.Stderr a configurable option.

How did I test it?

replace directive in go.mod of a project that uses hamba/cmd.

nrwiersma
nrwiersma approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrwiersma nrwiersma merged commit a606098 into hamba:main Mar 10, 2025
3 checks passed
@antiphp antiphp deleted the stdout branch March 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrwiersma nrwiersma nrwiersma approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antiphp @nrwiersma