README.md: Removing jwtGithubAudience default #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the documented default value for the jwtGithubAudience parameter in the README.md to match the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
README.mdfle by removing the documented default value for thejwtGithubAudienceparameter in the README.md to match the action.Ref: https://github.com/hashicorp/vault-action/blob/main/action.yml#L85-L87
Closes #558
Checklist
Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
[N/A] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
[N/A] If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.