Enhancing signature validation in SAML Response#144
Closed
Conversation
… on signature for saml response & extending tests
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
jimlambrt
pushed a commit
that referenced
this pull request
Dec 30, 2024
* adding signature for assertion in saml provider, enhancing validation on signature for saml response & extending tests * remove duplicate tests * linting done * small cleanup + small fix to test * add helping comment * use cap/saml response types * making validation of signature of both fields as optional and adding unit tests to cover * changes to inlcude more validateSignature options for SAML * improving / fixing comments and var names * improving / fixing comments and var names * improving variable name * add validation to only allow one validateSignature option at one time * removing validateBothSignature option * Merge branch 'main' into VAULT-27387/himran92-enhance-signature-validation-for-saml-response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAML protocol allows signing of a Response, its Assertion(s), neither, or both. Since Assertion(s) are sub-elements of a Response, they are signed if the Response is signed. Today we are depending on the gosaml2 for signature validation. It only checks only one or the other be signed.
For security reasons, we would like to move towards always requiring both to be signed.
Changes in PR include:
Points blocking merge:
/caprelease needs to be manually cut after making any change to library?