Conversation
- adds a separate check to see if the return code from amazon was ami instance not found - added test cases
|
@savaki thank for this, but you seem to excessively and rather inappropriately use panic() in your tests. |
|
How about this instead? I've changed the panics to t.Fatal |
|
@savaki 👍 |
|
Is there anything else you'd like me to do before accepting this pull request? |
|
@savaki I cannot accept it, its up to @mitchellh. I can only suggest that if you want to discard log messages, you could wrap logger and make os.Stdout use ioutil.Discard, but that has no bearing on the PR. |
|
@savaki This pull has a lot of great stuff! Because of some changes I made to the Amazon stuff, it can't merge cleanly. I manually applied the change that specifically fixes #207. But some other changes in here are great too, such as the timeout stuff. I'm sorry I couldn't merge in your specific commit. Feel free to open another pull with the timeout, for example. |
Mitchell, here's a fix for this issue. Here's what I did: