chore: replace github.com/mitchellh/mapstructure with github.com/go-viper/mapstructure/v2 #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iper/mapstructure/v2
ghost
reviewed
Mar 10, 2025
|
Not blocked. Just do not like having outdated dependencies. Original dependency was deprecated by the owner, and the new one is a "blessed fork" that will be supported by viper team. And serf seems to be a low level dependency in quite a lot of packages that we use. So my motivation was to have the train moved in that direction. |
thaJeztah
reviewed
Sep 25, 2025
|
|
||
| require ( | ||
| github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e | ||
| github.com/go-viper/mapstructure/v2 v2.2.1 |
There was a problem hiding this comment.
This can probably updated to v2.4.0 now; https://github.com/go-viper/mapstructure/releases/tag/v2.4.0
|
cc @rmainwork are you a maintainer for this repo? Was curious as well if this project would update to the maintained / blessed fork (I'm trying to prevent dependency sprawl in my projects) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.