Add Ruby 3.1 to CI#558
Add Ruby 3.1 to CI#558dblock merged 5 commits intohashie:masterfrom petergoldstein:feature/add_ruby_3_1_and_update_rubocop
Conversation
Update Rubocop for recent Rubies Disable Rubocop run for Rubies before Ruby 2.4 Quote '3.0' in the CI configuration to ensure it loads a 3.0.x Ruby Set RUBYOPT="--disable_error_highlight" so Ruby 3.1 error matchers pass
dblock
left a comment
There was a problem hiding this comment.
I vote for upgrading rubocop and dropping some 2.x rubies.
| ruby: | ||
| - 3.0 | ||
| - 3.1 | ||
| - '3.0' |
There was a problem hiding this comment.
This is a problem for all entries, no? Let's make them all strings.
There was a problem hiding this comment.
Nope. It's only a problem for ones that end in zeroes.
3.0 -> 3
'3.0' -> 3.0
That said, I'm happy to make them all strings if you'd like.
There was a problem hiding this comment.
It looks nicer, but I don't care enough.
There was a problem hiding this comment.
I rolled it in to the 2.4 change.
Gemfile
Outdated
There was a problem hiding this comment.
Should we just drop unsupported rubies and move up?
There was a problem hiding this comment.
Happy to do that too. I don't think there's much benefit to such a wide range of Ruby support. If you specify a minimum you'd like to use, I can update the PR to reflect that.
There was a problem hiding this comment.
@dblock 2.4 is the floor for this, but if you want to pick 2.5 (which is EOLed for almost a year) or 2.6 (which is EOLing in about 2 months).
Generally I'm a big fan of keeping Ruby version range relatively narrow, and using gem versions to distinguish.
There was a problem hiding this comment.
I am OK with whatever gives us one single version of Rubocop without the if's.
We tend not to remove rubies in Hashie because it has such incredibly wide use unless there's a good reason, and this is a good reason.
There was a problem hiding this comment.
Ok. I've put up a commit that sets the minimum version at 2.4 and updates existing code to reflect that.
Remove a number of code bits designed to support Rubies below version 2.4
dblock
left a comment
There was a problem hiding this comment.
Can we require Ruby 2.4 in gemspec and bump version to 5.1?
@michaelherold anything else?
Gemfile
Outdated
There was a problem hiding this comment.
I don’t think we still need this.
|
@dblock Those updates are in with the latest commit. |
There was a problem hiding this comment.
Thanks for doing this! Will wait a bit for @michaelherold and will merge this week otherwise. Not sure what Danger problem is, probably something about the token and permissions changes on GH.
|
@dblock I'm assuming you don't need anything else from me at this point, and will just merge this when you have a chance. Please let me know if there's anything else that I can do to help this get merged. Thanks! And thanks for your work on Hashie! |
|
I merged this, thank you. |
In addition to adding Ruby 3.1 to the CI configuration a number of other changes were required to get everything to pass. This included: