Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix #78, handle permissions for docker.sock in a better way #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2018
Merged

fix #78, handle permissions for docker.sock in a better way #82

merged 4 commits into from
Jul 27, 2018
+12 −15

Conversation

@shahidhk
Copy link
Member

@tirumaraiselvan This PR fixes #78. But, while testing some other issue with certain parameters in sshd_config being deprecated has appeared. Please check once before merging.

The following lines appear continuously with different port numbers in the logs for gitkubed:

rexec line 19: Deprecated option KeyRegenerationInterval
rexec line 20: Deprecated option ServerKeyBits
rexec line 31: Deprecated option RSAAuthentication
rexec line 38: Deprecated option RhostsRSAAuthentication
Could not load host key: /etc/ssh/ssh_host_dsa_key
Did not receive identification string from 10.1.0.1 port 43146

tirumaraiselvan
tirumaraiselvan requested changes Jun 26, 2018
View reviewed changes
Copy link
Collaborator

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this on minikube? I can't run minikube on mine :/

Have tested this on GKE.

build/gitkubed/start_sshd.sh
@@ -1,12 +1,16 @@
#!/usr/bin/env sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove /hasura-data/group mount from the deployment.

@tirumaraiselvan
Copy link
Collaborator

To remove the deprecated messages in the logs, just remove the deprecated options from sshd_config

sed -i '/KeyRegenerationInterval/d' /etc/ssh/sshd_config
sed -i '/ServerKeyBits/d' /etc/ssh/sshd_config
sed -i '/RSAAuthentication/d' /etc/ssh/sshd_config
sed -i '/RhostsRSAAuthentication/d' /etc/ssh/sshd_config

@tirumaraiselvan
Copy link
Collaborator

Also comment the line HostKey /etc/ssh/ssh_host_dsa_key to remove the host_dsa_key line

@shahidhk
Copy link
Member Author

@tirumaraiselvan To remove the deprecated messages, you've mentioned /etc/ssh/sshd_config. But aren't we using /sshd-lib/sshd_config?

@tirumaraiselvan
Copy link
Collaborator

@shahidhk Right. You just need to remove it from here https://github.com/hasura/gitkube/blob/master/build/gitkubed/sshd_config

@shahidhk
Copy link
Member Author

I figured.

@shahidhk
Copy link
Member Author

@tirumaraiselvan Any idea about Did not receive identification string from 172.17.0.1 port 58866?

@tirumaraiselvan tirumaraiselvan merged commit 87e6edb into hasura:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[gitkubed] Goes to CrashLoopBackOff on Docker for Desktop

2 participants

@shahidhk @tirumaraiselvan