Much faster rethrow(err, 'system') #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of this PR is to apply a hack that dramatically speeds up standard
Bounce.rethrow(err, 'system')calls (when not matching).This is done by adding a hidden property to each system error prototype, which can be tested for quickly. This replaces a series of slow
instanceofchecks. In my quick benchmark, I saw a ~50x speed increase!Care has been taken to implement this in a compatible manner, since system errors with custom
[Symbol.hasInstance]logic could otherwise fail. Since none of the existing system errors currently does this, I have had to add one such error during testing, to retain coverage.