Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add typescript typings #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kanongil wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Add typescript typings #39

kanongil wants to merge 2 commits into from

Conversation

@kanongil
Copy link
Contributor

@kanongil kanongil commented Oct 23, 2024

I made my own typings, including the changes in the not yet merged #37.

@kanongil kanongil added the types TypeScript type definitions label Oct 23, 2024
@Marsup
Copy link
Contributor

Marsup commented Oct 23, 2024

Should we start with #34 (if I can make it work) and then move on with this one or is it not worth it?

@damusix
Copy link

damusix commented Oct 23, 2024

Should we start with #34 (if I can make it work) and then move on with this one or is it not worth it?

@Marsup Na, not worth it since this covers everything that would be up-to-date. There's really no benefit to #34 if this covers all typings, and does so more effectively.

@kanongil kanongil mentioned this pull request Aug 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damusix damusix damusix approved these changes

Assignees

No one assigned

Labels

types TypeScript type definitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanongil @Marsup @damusix