Throw more helpful error message when config extension is not supported #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If people are using an older version of Node.js, it will fail to import files with some extensions, such as .ts or .mts. The error message is not very helpful, it just says it is an unknown file extension. I'm hoping we can help people out a little here by providing a more useful error message.
There was a problem hiding this comment.
Pull request overview
This PR enhances error messaging when users attempt to use config file extensions that aren't supported by their current Node.js version. Instead of showing a generic "unknown file extension" error, users now receive a helpful message directing them to upgrade Node.js to a version with native TypeScript support.
Key Changes:
- Added try-catch block around config file import to catch
ERR_UNKNOWN_FILE_EXTENSIONerrors - Throws a descriptive
TypeErrorwith specific Node.js version recommendations when unsupported extensions are detected - Added test coverage for the new error handling behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/config/loadConfig.ts | Wraps config import in try-catch to detect unsupported file extensions and throws helpful error message with Node.js version guidance |
| src/config/tests/loadConfig.test.ts | Adds test case verifying the improved error message when loading config files with unsupported extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If people are using an older version of Node.js, it will fail to import files with some extensions, such as .ts or .mts. The error message is not very helpful, it just says it is an unknown file extension. I'm hoping we can help people out a little here by providing a more useful error message.