Handle 409 status codes from cancel job API endpoint and pass error message through when canceling #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances error handling for the job cancellation endpoint by gracefully handling 409 status codes (when a job is already completed) and improves error messaging by passing through the actual error message instead of relying on the environment's message field.
- Adds try-catch error handling for 409 responses from the cancel job API
- Refactors
cancelJobto accept message as a direct parameter instead of extracting it fromEnvironmentResult - Updates the error log message to include integration type context
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/network/cancelJob.ts | Imports ErrorWithStatusCode, adds message as explicit parameter, wraps API call in try-catch to handle 409 status codes gracefully |
| src/cli/index.ts | Constructs error message from caught exception and passes it directly to cancelJob instead of relying on environment.message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e80b211 to
a43c113
Compare
This happens when the job has already been completed. This is normal behavior, so we don't want to throw here. We should possibly also handle 404 this way, which happens when no job is found for the pair of SHAs. I see that error reported fairly frequently, but I don't really understand how it comes about yet, so I don't want to jump into it here just yet.
This will update the job with some more useful information.
a43c113 to
7af205d
Compare
trotzig
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle 409 status codes from cancel job API endpoint
This happens when the job has already been completed. This is normal
behavior, so we don't want to throw here.
We should possibly also handle 404 this way, which happens when no job
is found for the pair of SHAs. I see that error reported fairly
frequently, but I don't really understand how it comes about yet, so I
don't want to jump into it here just yet.
Pass error message through when canceling jobs
This will update the job with some more useful information.