Handle HTTP 204 No Content in makeHappoApiRequest #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no content, calling `response.json()` results throws an error "Unecpected end of JSON input". We can avoid this by returning null when we receive a 204 status code. The cancel API endpoint behaves this way, so this should make the ride there a little smoother.
There was a problem hiding this comment.
Pull request overview
This PR adds support for handling HTTP 204 No Content responses in the makeHappoAPIRequest function. When a 204 status is received, the function now returns null instead of attempting to parse an empty response as JSON, which would throw an "Unexpected end of JSON input" error. This particularly benefits the cancel API endpoint which returns 204.
- Added early return of
nullwhen response status is 204 - Added test coverage for 204 No Content responses
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/network/makeHappoAPIRequest.ts | Added status code check to return null for 204 responses before attempting JSON parsing |
| src/network/tests/makeHappoAPIRequest.test.ts | Added test server endpoint and test case to verify null is returned for 204 responses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no content, calling
response.json()results throws an error "Unecpected end of JSON input". We can avoid this by returning null when we receive a 204 status code. The cancel API endpoint behaves this way, so this should make the ride there a little smoother.