Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

User configurable temporary fail delay times#2969

Merged
msimerson merged 8 commits intoharaka:masterfrom
superman20:temp_fail_delay
Sep 23, 2021
Merged

User configurable temporary fail delay times#2969
msimerson merged 8 commits intoharaka:masterfrom
superman20:temp_fail_delay

Conversation

@superman20
Copy link
Collaborator

Changes proposed in this pull request:

  • Add a new config option in outbound to allow configuration of delay times
  • The configuration would look something like (see the docs for specifics):
    temp_fail_intervals = 1m, 5m, 9m, 15m*3, 30m*10, 1h*6, 2h*6

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@msimerson
Copy link
Member

a. I like this change
b. I'd love to see some test coverage of set_temp_fail_intervals
c. after giving others time to look it over, I'll merge it even without b.

@superman20
Copy link
Collaborator Author

I'm not opposed to testing, but not sure how it works here. I'll have to learn the details first. Is there any helpful information on getting started with that? Also, I wrote the parsing code to fail over back to the original 2^N method at any sign of trouble...although I'm not saying someone couldn't input something that would totally break it. I might need to add a limit on the array size to keep someone from consuming too much memory with a ridiculous multiplier.

@msimerson
Copy link
Member

Is there any helpful information on getting started with that?

Looking at the existing tests is the best documentation we have.

I wrote the parsing code to fail over back

👍

I might need to add a limit on the array size to keep someone from consuming too much memory with a ridiculous multiplier.

That's something test coverage could help answer.

@superman20
Copy link
Collaborator Author

I added some tests. Please let me know if that meets your expectations.

Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@msimerson msimerson merged commit 6f336e1 into haraka:master Sep 23, 2021
@superman20 superman20 deleted the temp_fail_delay branch September 23, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants