spamassassin: replace msg_too_big with should_skip#2972
Merged
msimerson merged 4 commits intoharaka:masterfrom Oct 7, 2021
Merged
spamassassin: replace msg_too_big with should_skip#2972msimerson merged 4 commits intoharaka:masterfrom
msimerson merged 4 commits intoharaka:masterfrom
Conversation
f3cc53e to
e23f9fa
Compare
superman20
reviewed
Oct 7, 2021
Collaborator
superman20
left a comment
There was a problem hiding this comment.
Looks good to me. The only thing that caught my eye was the mixed logic of returning (for max size) vs flowing through (for everything else) in should_skip. Any reason to have the flow through logic at all? My personal preference would be to return on the first condition that resulted in skipping unless there was value in tracking all the conditions that would have caused skipping.
to be consistent with other plugins that implement should_skip
d1ac92f to
604d464
Compare
Member
Author
I've made the logic consistent (pass through) and added a comment on why (populate transaction results fully for statistical analysis). |
superman20
approved these changes
Oct 7, 2021
Collaborator
superman20
left a comment
There was a problem hiding this comment.
Definitely like the consistency better. Looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces
msg_too_bigandshould_checkwithshould_skip, to be consistent with other plugins that implement should_skipsimilar / related to #2564 and #2927