Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 2, 2024

Bumps jfmengels/elm-review-simplify from 2.1.3 to 2.1.4.

Changelog

Sourced from jfmengels/elm-review-simplify's changelog.

[2.1.4] - 2024-04-01

The rule now simplifies unnecessary wrapping of values evaluated by a case expression:

case Just value of
    Nothing -> a
    Just (Ok b) -> c
    Just (Err d) -> e

is simplified to

case value of
    Ok b -> c
    Err d -> e

(same with any variant, list or tuple containing either)

The rule also simplifies (thanks to [@​morteako]):

  • Array.length (Array.fromList list) to List.length list
  • List.length (Array.toList array) to Array.length array (same for Array.toIndexedList)
  • List.isEmpty (Array.toList array) to Array.isEmpty array (same for Array.toIndexedList)
  • List.length (Set.toList set) to Set.size set
  • List.isEmpty (Set.toList set) to Set.isEmpty set
  • List.length (Dict.toList dict) to Dict.size dict (same for Dict.values and Dict.keys)
  • List.isEmpty (Dict.toList dict) to Dict.isEmpty dict (same for Dict.values and Dict.keys)

Bug fixes:

Commits
  • a529f9a 2.1.4
  • edf643e Update CHANGELOG
  • 1904b6b Nested Maybe case-of to Maybe.map2
  • cac3ce8 Split caseVariantOfWithUnreachableCasesChecks into single- and multi-variant
  • f00fe0c Let introduce caseIndexesMatchingOnDifferentVariant
  • c3cb473 Convert some findMaps to firstThatConstructsJust
  • cbf1e07 Move shared data out of cases
  • b990be2 replace nested Maybe case with Maybe.map2
  • 0073354 split off error helpers to reduce indentation
  • 7fb0bfa If all but one cases are unreachable, fix to result of remaining case
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jfmengels/elm-review-simplify](https://github.com/jfmengels/elm-review-simplify) from 2.1.3 to 2.1.4.
- [Changelog](https://github.com/jfmengels/elm-review-simplify/blob/main/CHANGELOG.md)
- [Commits](jfmengels/elm-review-simplify@2.1.3...2.1.4)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review-simplify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added automerge dependencies Pull requests that update a dependency file labels Apr 2, 2024
@github-actions github-actions bot merged commit 1550834 into master Apr 2, 2024
@dependabot dependabot bot deleted the dependabot/elm/frontend/review/jfmengels/elm-review-simplify-2.1.4 branch April 2, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant