feat: change status from optional to required #9234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5582547 to
c6adfc7
Compare
There was a problem hiding this comment.
LGTM for the source code changes — just a small nit, thanks.
For the test plan, IMO, we might expand it to verify compatibility in the following areas:
-
VM Snapshot creation and restoration
-
Scheduled VM Backup creation and restoration
-
Cross-cluster VM Backup discovery between old and new Harvester versions:
- Cluster1 (v1.7) creates a new VM Backup → Cluster2 (v1.6) discovers and restores it
- Cluster2 (v1.6) creates a new VM Backup → Cluster1 (v1.7) discovers and restores it
| } | ||
|
|
||
| if restore.Status == nil { | ||
| if restore.Status.Complete == nil { |
There was a problem hiding this comment.
Consider factoring this into a separate function.
There was a problem hiding this comment.
Thanks for the review. Addressed all comments.
| // We need to delete VolumeSnapshotContent by restore controller, or there will have remaining VolumeSnapshotContent in the system. | ||
| func (h *RestoreHandler) RestoreOnRemove(_ string, restore *harvesterv1.VirtualMachineRestore) (*harvesterv1.VirtualMachineRestore, error) { | ||
| if restore == nil || restore.Status == nil { | ||
| if restore == nil || restore.Status.Complete == nil { |
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
c6adfc7 to
51402a7
Compare
Signed-off-by: PoAn Yang <[email protected]>
51402a7 to
352af80
Compare
WebberHuang1118
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Related Issue(s):
#6126
Test plan:
New cluster
Upgrade path
Cross-cluster VM Backup discovery between old and new Harvester versions:
Additional documentation or context